Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh_CN: translation js_guide_save_load.md #694

Merged

Conversation

@PeterJaq
Copy link
Contributor

commented Jun 17, 2019

No description provided.

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 17, 2019

Reviewers added, please take a look.
@kuri-leo

When your review is finished, approve the pull request or include "LGTM" in your comment.

@lamberta

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Thanks, Jiang.

@duanw0916, can you please find a reviewer for this pull request? Thank you

site/zh-cn/js/guide/save_load.md Outdated Show resolved Hide resolved
site/zh-cn/js/guide/save_load.md Outdated Show resolved Hide resolved
site/zh-cn/js/guide/save_load.md Outdated Show resolved Hide resolved
site/zh-cn/js/guide/save_load.md Outdated Show resolved Hide resolved
site/zh-cn/js/guide/save_load.md Outdated Show resolved Hide resolved
site/zh-cn/js/guide/save_load.md Outdated Show resolved Hide resolved
site/zh-cn/js/guide/save_load.md Outdated Show resolved Hide resolved
site/zh-cn/js/guide/save_load.md Outdated Show resolved Hide resolved
site/zh-cn/js/guide/save_load.md Outdated Show resolved Hide resolved
site/zh-cn/js/guide/save_load.md Outdated Show resolved Hide resolved
@kuri-leo

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

Thanks, Jiang.

@duanw0916, can you please find a reviewer for this pull request? Thank you

Hi @lamberta, Sorry for my temporary disappearance but it will continue to the next week as I'm deeply trapped in the nightmare of final exams 🤦‍♂

I will be back as soon as my college troubles were finished (or I was finished, and review those left PRs & give patches to the merged (They seem to have problems left ).

Thanks

Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
@googlebot

This comment has been minimized.

Copy link

commented Jul 1, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 1, 2019

PeterJaq and others added some commits Jul 1, 2019

Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
@googlebot

This comment has been minimized.

Copy link

commented Jul 1, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@lamberta

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

@kuri-leo No worries at all! Appreciate all your work here to build the community and please do well on your exams :)

Some more reviewers have graciously volunteered to help. FYI @JayYip, @yantaozhao, @loveunk, @Wind2esg

Thank you, all!

@kuri-leo

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

mark, review during weekend

PeterJaq and others added some commits Jul 16, 2019

Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
@googlebot

This comment has been minimized.

Copy link

commented Aug 12, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 12, 2019

Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
@googlebot

This comment has been minimized.

Copy link

commented Aug 12, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

PeterJaq and others added some commits Aug 12, 2019

Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/guide/save_load.md
Co-Authored-By: kurileo <twkuri@gmail.com>
@kuri-leo
Copy link
Contributor

left a comment

LGTM

@lamberta
Copy link
Member

left a comment

Thanks, all!

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit ffeff2f into tensorflow:master Aug 12, 2019

3 checks passed

Ubuntu Sanity Check Internal CI build successful
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.