Skip to content

Update version check for R package #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Update version check for R package #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0ffc45
Update R package to require tf version >= 1.13.0
terrytangyuan Mar 1, 2019
ecedb99
Update SystemRequirements with TensorFlow IO minimum version
terrytangyuan Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R-package/DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Description: Interface to 'TensorFlow IO', Datasets and filesystem extensions ma
License: Apache License 2.0
URL: https://github.com/tensorflow/io
BugReports: https://github.com/tensorflow/io/issues
SystemRequirements: TensorFlow >= 1.4 (https://www.tensorflow.org/)
SystemRequirements: TensorFlow >= 1.13.0 (https://www.tensorflow.org/) and TensorFlow IO >= 0.4.0 (https://github.com/tensorflow/io)
Encoding: UTF-8
LazyData: true
Depends:
Expand Down
6 changes: 3 additions & 3 deletions R-package/R/package.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ tfio_module_not_available_message <- function() {

check_tensorflow_version <- function(displayed_warning) {
current_tf_ver <- tf_version()
required_ver <- "1.12.0"
if (current_tf_ver != required_ver) {
min_ver <- "1.13.0"
if (current_tf_ver < min_ver) {
if (!displayed_warning) {
packageStartupMessage(
"tfio requires TensorFlow version == ", required_ver, " ",
"tfio requires TensorFlow version >= ", min_ver, " ",
"(you are currently running version ", current_tf_ver, ").\n")
displayed_warning <<- TRUE
}
Expand Down