Fix temporary file issue in s3 #1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
requested review from
burgerkingeater,
kvignesh1420 and
terrytangyuan
terrytangyuan
approved these changes
Sep 9, 2021
kvignesh1420
reviewed
Sep 9, 2021
| kS3FileSystemAllocationTag, nullptr, "_s3_filesystem_XXXXXX", | ||
| kS3FileSystemAllocationTag, | ||
| #if defined(_MSC_VER) | ||
| nullptr, |
Member
There was a problem hiding this comment.
@yongtang where will be the temporary files be created if it is a nullptr?
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Member
Author
|
@kvignesh1420 The temp file will be on the same directory on Windows. Added a comment in the code which matches: |
dopiera
pushed a commit
to Unoperate/tensorflow_io
that referenced
this pull request
Dec 3, 2021
* Fix temporary file issue Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Add additional comment for reason of passing nullptr. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
zheolong
pushed a commit
to zheolong/io-1
that referenced
this pull request
Jul 24, 2025
* Fix temporary file issue Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Add additional comment for reason of passing nullptr. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the temporary file issue in s3 where temp files are created within the current directory.
This PR maintains the behavior of old s3 file system.
This PR fixes #1519.
Signed-off-by: Yong Tang yong.tang.github@outlook.com