Skip to content

Fix temporary file issue in s3 #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Fix temporary file issue in s3 #1526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fbe579
Fix temporary file issue
yongtang Sep 9, 2021
2149fab
Add additional comment for reason of passing nullptr.
yongtang Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions tensorflow_io/core/filesystems/s3/s3_filesystem.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,18 @@ typedef struct S3File {
s3_client(s3_client),
transfer_manager(transfer_manager),
outfile(Aws::MakeShared<Aws::Utils::TempFile>(
kS3FileSystemAllocationTag, nullptr, "_s3_filesystem_XXXXXX",
kS3FileSystemAllocationTag,
#if defined(_MSC_VER)
// On Windows, `Aws::FileSystem::CreateTempFilePath()` return
// `C:\Users\username\AppData\Local\Temp\`. Adding template will
// cause an error.
nullptr,
Copy link
Member

@kvignesh1420 kvignesh1420 Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yongtang where will be the temporary files be created if it is a nullptr?

#else
"/tmp/_s3_filesystem_XXXXXX",
#endif
std::ios_base::binary | std::ios_base::trunc | std::ios_base::in |
std::ios_base::out)) {}
std::ios_base::out)) {
}
} S3File;

void Cleanup(TF_WritableFile* file) {
Expand Down