Enable and Fix Arrow tests for TF 1.15.0 #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes Arrow test failures from #431 |
BryanCutler
force-pushed
the
fix-arrow-tf-1_15rc1
branch
from
e833998 to
78357a2
Compare
BryanCutler
commented
Sep 30, 2019
|
|
||
|
|
||
| class ArrowBaseDataset(data.Dataset): | ||
| class ArrowBaseDataset(dataset_ops.DatasetV2): |
There was a problem hiding this comment.
Is this ok to use as a base for 1.15.0?
There was a problem hiding this comment.
That should be OK I think. As long as dataset could be passed to tf.keras (with 1.15 and 2.0) we should be fine. Both DatasetV1 and DatasetV2 works with tf.keras. 👍
|
Actually it might be easier to PR against master, then cherry-pick or rebase in R0.8 instead. As the Google CLA will post some issues in R0.8 branch. Let me fix that. |
yongtang
pushed a commit
that referenced
this pull request
Oct 1, 2019
|
Cherry-picked to master and fixed the CLA issue. |
|
Thanks @yongtang ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects API issues with TF 1.15.0 and fixes a bug in reading ArrowStreamDataset messages causing test failures. Arrow tests are now all enabled.