Add interleave support into IgniteDataset#59
Merged
dmitrievanthony merged 2 commits intotensorflow:masterfrom Jan 22, 2019
Merged
Add interleave support into IgniteDataset#59dmitrievanthony merged 2 commits intotensorflow:masterfrom
dmitrievanthony merged 2 commits intotensorflow:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
IgniteDatasetmakes a call to data source during construction (in python) to retrieve a data schema. When we useDataset.interleaveit doesn't work well becausehostandportobjects are tensors during the construction, notstring/intvalues. This fact is also reflected in Apache JIRA in this issue.To eliminate this problem I propose to use separate
host/portobjects to be used to retrieve schema and to retrieve data itself. Please have a look at the changed tests in this PR for details.