Skip to content
This repository was archived by the owner on Apr 10, 2024. It is now read-only.

Conversation

@arvind
Copy link
Contributor

@arvind arvind commented Jun 1, 2018

#60 only partially fixed the issue of auto generated names. This PR catches the other instance of invalid component names due to dash-separated uuids.

@arvind arvind requested a review from colah June 1, 2018 20:59
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@coveralls
Copy link

coveralls commented Jun 1, 2018

Pull Request Test Coverage Report for Build 160

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 64.05%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lucid/scratch/web/svelte.py 0 6 0.0%
Totals Coverage Status
Change from base Build 154: -0.09%
Covered Lines: 930
Relevant Lines: 1452

💛 - Coveralls

@googlebot
Copy link

CLAs look good, thanks!

@arvind
Copy link
Contributor Author

arvind commented Jun 1, 2018

Once we merge, this should probably warrant a version bump @ludwigschubert.

@ludwigschubert
Copy link
Contributor

How did we never merge this? Thanks, @arvind!

@ludwigschubert ludwigschubert merged commit 10d86f3 into master Nov 28, 2018
@ludwigschubert ludwigschubert deleted the js_id branch November 28, 2018 01:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants