Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 18, 2017

flake8 testing of https://github.com/tensorflow/models on Python 2.7.13

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./cognitive_mapping_and_planning/cfgs/config_distill.py:94:33: F821 undefined name 'resnet_v2_50_path'
  args.solver.pretrained_path = resnet_v2_50_path
                                ^

./cognitive_mapping_and_planning/src/depth_utils.py:26:19: F821 undefined name 'utils'
  camera_matrix = utils.Foo(xc=xc, zc=zc, f=f)
                  ^

./cognitive_mapping_and_planning/src/file_utils.py:36:14: F821 undefined name 'file_name'
  with fopen(file_name, 'r') as f:
             ^

./cognitive_mapping_and_planning/src/file_utils.py:38:10: F821 undefined name 'np'
    II = np.array(I)
         ^

./cognitive_mapping_and_planning/src/graph_utils.py:453:7: F821 undefined name 'logging'
      logging.error('Did not find any good nodes.')
      ^

./cognitive_mapping_and_planning/src/graph_utils.py:468:14: F821 undefined name 'get_path_ids'
      path = get_path_ids(start_node_ids[i], end_node_ids[i], pred_map)
             ^

./cognitive_mapping_and_planning/src/graph_utils.py:511:7: F821 undefined name 'logging'
      logging.error('Did not find any good nodes.')
      ^

./cognitive_mapping_and_planning/src/graph_utils.py:517:14: F821 undefined name 'get_path_ids'
      path = get_path_ids(start_node_ids[i], end_node_ids[i], pred_map)
             ^

./cognitive_mapping_and_planning/src/graph_utils.py:547:14: F821 undefined name 'get_path_ids'
      path = get_path_ids(start_node_ids[i], end_node_ids[i], pred_map)
             ^

./cognitive_mapping_and_planning/src/map_utils.py:143:7: F821 undefined name 'logging'
      logging.error('Unknown resizing method')
      ^

./cognitive_mapping_and_planning/tfcode/vision_baseline_lstm.py:152:21: F821 undefined name 'is_training'
        is_training=is_training)
                    ^

cclauss added 4 commits July 18, 2017 20:21
$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__

```
./object_detection/utils/label_map_util_test.py:79:19: E999 IndentationError: expected an indented block
    label_map_proto = string_int_label_map_pb2.StringIntLabelMap()
                  ^
```
@derekjchow
Copy link
Contributor

The object_detection changes look good to me. If you can separate them into another PR, I can merge them.

@cclauss cclauss mentioned this pull request Aug 3, 2017
cclauss added 2 commits August 3, 2017 10:19
Changes to object_detection/utils/label_map_util_test.py moved to #2013
@cclauss
Copy link
Contributor Author

cclauss commented Aug 3, 2017

@s-gupta Can you please look at the cognitive_mapping_and_planning/src changes?

@s-gupta
Copy link
Contributor

s-gupta commented Aug 4, 2017

These look good to me. Thanks for all the fixes!

@cclauss cclauss changed the title Resolve some of the issues found in flake8 testing Cog_Map: Resolve issues found in flake8 testing Aug 10, 2017
@cclauss
Copy link
Contributor Author

cclauss commented Sep 4, 2017

@s-gupta nudge

@s-gupta
Copy link
Contributor

s-gupta commented Sep 4, 2017

Sorry for the late reply. Line 32 does import matplotlib.pyplot as plt and should be deleted as it is now being done on line 50 after matplotlib.use("Agg"). Thanks!

@s-gupta
Copy link
Contributor

s-gupta commented Sep 4, 2017

Thanks! Looks good to me.

@cclauss
Copy link
Contributor Author

cclauss commented Sep 8, 2017

@s-gupta I am unsure of the process here. Are you the maintainer of cognitive mapping and planning or does someone else need to merge this?

@s-gupta
Copy link
Contributor

s-gupta commented Sep 8, 2017

I wrote this code and prepared the pull request to merge it but I dont have write permission to this repository. Someone from Google merges is I believe.

@cclauss
Copy link
Contributor Author

cclauss commented Sep 8, 2017

Yes. That is the sense that I got. Thanks for your guidance.

@cclauss cclauss changed the title Cog_Map: Resolve issues found in flake8 testing Cog_Map: Resolve 11 undefined names that could raise NameError at runtime Sep 10, 2017
@cclauss cclauss closed this Jan 27, 2018
@cclauss cclauss deleted the patch-2 branch January 27, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants