-
Notifications
You must be signed in to change notification settings - Fork 45.3k
Cog_Map: Resolve 11 undefined names that could raise NameError at runtime #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__
```
./object_detection/utils/label_map_util_test.py:79:19: E999 IndentationError: expected an indented block
label_map_proto = string_int_label_map_pb2.StringIntLabelMap()
^
```
|
The object_detection changes look good to me. If you can separate them into another PR, I can merge them. |
Changes to object_detection/utils/label_map_util_test.py moved to #2013
|
@s-gupta Can you please look at the cognitive_mapping_and_planning/src changes? |
|
These look good to me. Thanks for all the fixes! |
As requested in #1981 (comment)
|
@s-gupta nudge |
|
Sorry for the late reply. Line 32 does |
|
Thanks! Looks good to me. |
|
@s-gupta I am unsure of the process here. Are you the maintainer of cognitive mapping and planning or does someone else need to merge this? |
|
I wrote this code and prepared the pull request to merge it but I dont have write permission to this repository. Someone from Google merges is I believe. |
|
Yes. That is the sense that I got. Thanks for your guidance. |
flake8 testing of https://github.com/tensorflow/models on Python 2.7.13
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics