object_detection exporter updates #2053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: We use two different Saver objects during training, one to initialize from a checkpoint and another to save and restore from checkpoints during training. Both these Savers were bound to same variable name causing init_fn function to use the latter instead of the former when called.
This change is required to enable object detection export and inference with dynamic batch size.
A few change to prepare for batch inference: * Modify the return type of batch non max suppression to be tuple of tensors so it can be reused for both stages of faster rcnn without any confusion in the semantics implied the the keys used to represent the tensors. * Allow dynamic number of anchors (boxes) in addition to dynamic batch size. * Remove a redundant dynamic batch size test.
* Adds a util function to compute a mix of dynamic and static shapes preferring static when available. * Uses batch_multiclass_non_max_suppression function in postprocess_rpn instead of looping over static batch shape and performing multiclass_non_max_suppression. * Adds a new helper function _unpad_proposals_and_sample_boxclassifier_batch to sample from a batch of tensors possibly containing paddings. * Tests batch inference with various configurations of static shape via unittests.
* Creates a new batch_decode method in SSD Meta architecture that can handle dynamic batch size. * use combined_shapes in _get_feature_maps_spatial_dims method to handle dynamic batch image_size. * Add dynamic batch size tests to check preprocess, predict and postprocess methods in SSD Meta architecture.
tombstone
reviewed
Jul 28, 2017
| TODO: revisit whether it's possible to force the `Repeat` namescope as | ||
| created in `_extract_box_classifier_features` to start counting at 2 (e.g. | ||
| `Repeat_2`) so that the default restore_fn can be used. | ||
| TODO(jonathanhuang,rathodv): revisit whether it's possible to force the |
There was a problem hiding this comment.
can you purge the names ?
tombstone
suggested changes
Jul 28, 2017
|
PTAL. |
tombstone
approved these changes
Jul 28, 2017
|
@derekjchow you rock! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.