Conversation
tfboyd
requested changes
Feb 28, 2019
|
|
||
| def benchmark_8_gpu_bfc_allocator(self): | ||
| """Restricts CPU memory allocation.""" | ||
| def benchmark_8_gpu_tweaked(self): |
Member
There was a problem hiding this comment.
Can you go ahead and delete this test completely and make the test above def benchmark_8_gpu(self): run with the 14 threads. Since the goal for this class of tests is to test accuracy first it is ok for the accuracy test to be "tuned". The short test are our primary location for perf tests. I realize this is a bit weird. If the accuracy tests did not take 16 hours I would have a normal and then tweaked version. Thank you and this is a great test to track our progress.
added 2 commits
February 28, 2019 13:02
tfboyd
approved these changes
Feb 28, 2019
Member
tfboyd
left a comment
tfboyd
left a comment
There was a problem hiding this comment.
LGTM, you rock. Not having to add all the tests myself is awesome. Seems silly but I us to add and manage them. Team work is so much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed the bfc allocator one. We'll add GPU thread pool, inter op, intra op pool later.