Skip to content

Fixing small problems in the example code#8950

Open
yassersouri wants to merge 2 commits intotensorflow:masterfrom
yassersouri:patch-1
Open

Fixing small problems in the example code#8950
yassersouri wants to merge 2 commits intotensorflow:masterfrom
yassersouri:patch-1

Conversation

@yassersouri
Copy link

@yassersouri yassersouri commented Jul 23, 2020

Description

I was following up with the example code and found a few small issues in it. This is mainly about type incompatibility.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • TensorFlow 2 migration
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • A new research paper code implementation
  • Other (Specify)

Tests

Doesn't need test.

Test Configuration:

Checklist

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@yassersouri
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants