Skip to content

Made VGGish and YAMNet work in TF2 without disabling TF2 behavior.#9077

Merged
dpwe merged 3 commits intotensorflow:masterfrom
plakal:master
Aug 9, 2020
Merged

Made VGGish and YAMNet work in TF2 without disabling TF2 behavior.#9077
dpwe merged 3 commits intotensorflow:masterfrom
plakal:master

Conversation

@plakal
Copy link
Collaborator

@plakal plakal commented Aug 9, 2020

Allowed TF2 behavior and allowed passing in a features tensor into the
VGGish model definition. Both of these changes are needed for making
TF-Hub exports of these models. Lifted constraints on TF versions since
tf_slim has been updated to work with TF 2.

Description

📝 Please include a summary of the change.

  • Please also include relevant motivation and context.
  • List any dependencies that are required for this change.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Documentation update
  • TensorFlow 2 migration

Tests

📝 Please describe the tests that you ran to verify your changes.

  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Test Configuration:

VGGish: Ran vggish_smoke_test.py and vggish_inference_demo.py with latest TF1 and TF2
YAMNet: Only documentation change.

Checklist

Allowed TF2 behavior and allowed passing in a features tensor into the
VGGish model definition. Both of these changes are needed for making
TF-Hub exports of these models. Lifted constraints on TF versions since
tf_slim has been updated to work with TF 2.
@plakal plakal requested a review from dpwe August 9, 2020 05:08
dpwe
dpwe previously approved these changes Aug 9, 2020
@plakal plakal self-assigned this Aug 9, 2020
@plakal plakal requested a review from dpwe August 9, 2020 16:50
@dpwe dpwe merged commit 557eec2 into tensorflow:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants