Skip to content

cognitive_planning update to python3.x#9167

Open
moneypi wants to merge 1 commit intotensorflow:masterfrom
moneypi:update_cognitive_planning
Open

cognitive_planning update to python3.x#9167
moneypi wants to merge 1 commit intotensorflow:masterfrom
moneypi:update_cognitive_planning

Conversation

@moneypi
Copy link
Contributor

@moneypi moneypi commented Aug 30, 2020

Description

📝 Please include a summary of the change.
I get some error when I run cognitive_planning in Python3.8, so I try to fix these errors.
But I can't download AVD_Minimal.zip(https://storage.googleapis.com/active-vision-dataset/AVD_Minimal.zip) ......

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • TensorFlow 2 migration
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • A new research paper code implementation
  • Other (Specify)

Tests

📝 Please describe the tests that you ran to verify your changes.

  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Test Configuration:

Checklist

@jaeyounkim jaeyounkim self-assigned this Sep 18, 2020
@jaeyounkim
Copy link
Contributor

@arsalan-mousavian Can you review this PR?

@jaeyounkim jaeyounkim added the stat:awaiting review Waiting on review label Sep 18, 2020
@jaeyounkim jaeyounkim removed their assignment Oct 2, 2020
@jaeyounkim
Copy link
Contributor

@moneypi This model is not maintained anymore, and Arsalan Mousavian(@arsalan-mousavian) has not responded yet. This model will be achieved at the end of October unless Arsalan can help.

@jaeyounkim jaeyounkim self-requested a review October 2, 2020 20:18
@jaeyounkim jaeyounkim self-assigned this Oct 2, 2020
Copy link
Contributor

@arsalan-mousavian arsalan-mousavian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making changes for python3 compatibility.
LGTM

@laxmareddyp laxmareddyp added the models:research models that come under research directory label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes models:research models that come under research directory stat:awaiting review Waiting on review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants