Fix wrong parsing of model config given on command line#9281
Open
GPhilo wants to merge 1 commit intotensorflow:masterfrom
Open
Fix wrong parsing of model config given on command line#9281GPhilo wants to merge 1 commit intotensorflow:masterfrom
GPhilo wants to merge 1 commit intotensorflow:masterfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
564d42c to
82ec55e
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TF2 version of the SSD TFLite model exporter allows to pass a --config_override flag with a
TrainEvalPipelineConfigmessage to alter the givenpipeline_config. However, the script callsParseinstead ofMergewhen handling the flags. This raises an error for any non-repeated items in the message. For example, using the value in the script's documentation, it raises:Simply replacing
ParsewithMerge(similarly to how the TF1 version of the script handles the flag) solves the problem.Type of change
Tests
Run the script with the command shown in the example usage on any pre-trained SSD models from the TF2 model zoo.
Checklist
-> The change is minimal and self-explanatory
-> The fix makes the script work as already documented
-> I'm not sure how to add a test for this (I'm not familiar with the testing infrastructure and I couldn't find any example for the script or its TF1 version)