Remove extra checks from loop

[spirinvladimir]

Description

Loop with 2 conditions inside replaced with 3 loops without such conditions inside.

Type of change

Changes improve time complexity.

Note: Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• Documentation update
• TensorFlow 2 migration
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• A new research paper code implementation
• Other (performance)

Tests

Is any performance tests required?

Test Configuration:

Checklist

• I have signed the Contributor License Agreement.
• I have read guidelines for pull request.
• My code follows the coding guidelines.
• I have performed a self code review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[spirinvladimir]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[prabhukaliamoorthi]

Thanks for the change.

This loop is not critical to performance so I won't duplicate the loop to reduce comparisons.

[spirinvladimir]

@prabhukaliamoorthi I'm glad that you saw duplication of codebase. This was a trump sorry 😄 . Any way there is a general solution to move common parts to new function. Should I do it? I'm asking cause not clear how you calculate performance and what is critical? I calculate performance by by time complexity.

[prabhukaliamoorthi]

In general the loop you are optimizing is executed once for each token in the text. That particular code takes 1 - 2% of the overall inference time when profiled on an Android device. So optimizing it would not make a noticeable difference to the inference time. In such situation I prefer readability over performance.

[spirinvladimir]

Should I move code duplication to a function? You might want suggest a name to improve readability.
Code duplication isn't show stopper. It can be refactored.
About performance improvement:
Should not we accept any performance improvement even % of improvement is low?

I'm Vladimir Spirin. I as a part of open-source community want to be reviewed by other developers. Current code base have to be improved. Our code base mentioned at public news and I we should keep good code quality.

[prabhukaliamoorthi]

Sorry for the delayed reply. I need to move couple of internal changes to the github repo. So I am delaying this cl. One other thing is all the tests should pass.