sarkars/Possible fix for backend settings #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // splits into {"ngraph_backend", "_ngraph_device_config"} | ||
| config_map = BackendManager::GetBackendAttributeValues( | ||
| backend_name); // SplitBackendConfig | ||
| backend_name = config_map.at("ngraph_backend"); |
Contributor
Author
There was a problem hiding this comment.
removing this line so that in MarkForClustering we pass GPU:0 instead of GPU
kanvi-nervana
suggested changes
Jul 25, 2019
Co-Authored-By: kanvi-nervana <kanvi.khanna@intel.com>
ngraph_bridge/ngraph_rewrite_pass.cc
Outdated
|
|
||
| // 1. Mark for clustering then, if requested, dump the graphs. | ||
| std::set<string> skip_these_nodes = {}; | ||
| // For normal pass note that |
Contributor
There was a problem hiding this comment.
Is there more to this comment?
| } | ||
| } | ||
| config_backend_name = params.at("ngraph_backend").s(); | ||
| device_id = params.at("device_id").s(); |
Contributor
There was a problem hiding this comment.
May be change this to config_device_id to make it consistent with config_backend_name
…nsorflow/ngraph-bridge into sarkars/change_setnodebackend
kanvi-nervana
approved these changes
Jul 25, 2019
Contributor
kanvi-nervana
left a comment
kanvi-nervana
left a comment
There was a problem hiding this comment.
Minor comment about a comment, otherwise LGTM
| // backend dependent, which might change with different sess.run()s | ||
| confirmation_function_map["GatherV2"] = [¤t_backend](Node* n, | ||
| bool* result) { | ||
| // TODO: replace current_backend -> |
Contributor
There was a problem hiding this comment.
Is this comment still valid?
| << backend_creation_string; | ||
| } | ||
| NGRAPH_VLOG(0) << "NGraph using backend: " << backend_name; | ||
| NGRAPH_VLOG(0) << "NGraph using backend: " << config_backend_name; |
Contributor
There was a problem hiding this comment.
Should this log print the backend_name or the backend_creation_string?
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
_ngraph_backend attribute added to TF nodes will now be backend:device_id instead of just backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device_id != ""might not be working. This change tries to fix that. Need to discuss if there are any other implications