Vishakha/softplus #179
Merged
Vishakha/softplus #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayantan-nervana
approved these changes
Aug 5, 2019
| static Status TranslateSoftplusOp( | ||
| const Node* op, const std::vector<const Tensor*>& static_input_map, | ||
| Builder::OpMap& ng_op_map) { | ||
| shared_ptr<ng::Node> ng_inp; |
Contributor
There was a problem hiding this comment.
https://www.tensorflow.org/api_docs/cc/class/tensorflow/ops/softplus.html
log(exp(features) + 1)
Contributor
There was a problem hiding this comment.
May be add this - log(exp(features) + 1) as a comment for future reference.
kanvi-nervana
approved these changes
Aug 7, 2019
Contributor
kanvi-nervana
left a comment
kanvi-nervana
left a comment
There was a problem hiding this comment.
Minor comment otherwise LGTM :)
| static Status TranslateSoftplusOp( | ||
| const Node* op, const std::vector<const Tensor*>& static_input_map, | ||
| Builder::OpMap& ng_op_map) { | ||
| shared_ptr<ng::Node> ng_inp; |
Contributor
There was a problem hiding this comment.
May be add this - log(exp(features) + 1) as a comment for future reference.
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Softplus Op