Kanvi/bfloat16 tests #185
Merged
Kanvi/bfloat16 tests #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shresthamalik
suggested changes
Aug 7, 2019
Contributor
shresthamalik
left a comment
shresthamalik
left a comment
There was a problem hiding this comment.
Requested some changes
| ng_outval = sess_ng.run(ng_out[0], feed_dict=feed_dict) | ||
|
|
||
| # transpose TF output from NHWC to NCHW for comparison with ngraph output | ||
| assert (np.allclose( |
Contributor
There was a problem hiding this comment.
Do we care about only the 1st output of the op?
sindhu-nervana
suggested changes
Aug 8, 2019
remove fusedbatchnorm_inferece tests since those are not needed for resnet
kanvi-nervana
commented
Aug 8, 2019
kanvi-nervana
requested review from
sayantan-nervana,
shresthamalik and
sindhu-nervana
and removed request for
sayantan-nervana
sindhu-nervana
approved these changes
Aug 8, 2019
sayantan-nervana
added
fully reviewed
ready to merge
sayantan-nervana
approved these changes
Aug 8, 2019
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
This PR implements the following new tests to test the bfloat16 conversions test_fusedbatchnorm_training_nhwc.py test_fusedbatchnorm_training_nchw.py test_maxpoolbackprop_nhwc.py test_maxpoolbackprop_nhwc.py The following existing tests are also fixed as part of this PR test_fusedbatchnorm.py test_l2loss.py test_maxpoolbackprop.py test_relugrad.py test_sparse_softmax_cross_entropy_with_logits.py Also, made changes to the cmake so the new folder is included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following new tests to test the bfloat16 conversions
The following existing tests are also fixed as part of this PR
Also, made changes to the cmake so the new folder is included.