Skip to content

Conversation

@sayantan-nervana
Copy link
Contributor

@sayantan-nervana sayantan-nervana commented Nov 15, 2019

resizebilinear translation. uses ngraph op "interpolate", but that has no implementation in any backend, so gtest is disabled for now.

There are some TODOs in the PR, to be done when we have backends start supporting interpolate.

Copy link
Contributor

@shresthamalik shresthamalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ngraph::op::InterpolateAttrs attrs;
attrs.align_corners = align_corners;
attrs.mode = "linear";
attrs.antialias = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it always supposed to be false?

Copy link
Contributor

@kanvi-nervana kanvi-nervana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@sayantan-nervana sayantan-nervana merged commit 07a618c into r0.19 Nov 16, 2019
@sayantan-nervana sayantan-nervana deleted the sarkars/resize_bilinear_r19 branch November 16, 2019 02:18
sayantan-nervana added a commit that referenced this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants