Skip to content

Conversation

@shresthamalik
Copy link
Contributor

@shresthamalik shresthamalik commented Nov 27, 2019

ugrade ngraph_version = "e543688981ea2083a260929a70420f5ba6984d95"
Nagy Mostafa [MLIR] Fused Ops dialect declaration (#3860)

  • Fixed Parallel Executor to take in the node name

  • PTS asserts out if depth>0 but no of inputs and outputs is 0. Behavior to be fixed in another PR. Unit tests that have NoOp make a cluster with no inputs and outputs. disabled support of NoOp for them.

  • All pipelines except --var go to Parallel Executor.

@sindhu-nervana sindhu-nervana added the wip Work in progress label Dec 5, 2019
@shresthamalik shresthamalik changed the title upgrade ng-core to master shrestha/upgrade ng-core to master Dec 6, 2019
@shresthamalik shresthamalik removed the wip Work in progress label Dec 7, 2019
Copy link
Contributor

@sindhu-nervana sindhu-nervana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shresthamalik shresthamalik merged commit 1816c46 into master Dec 10, 2019
@shresthamalik shresthamalik deleted the shrestha/upgrade_to_ng_core branch December 10, 2019 01:45
m_graph_id(graph_id),
m_graph(std::move(graph)),
m_op_backend_name(backend_name),
m_node_name(node_name),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is m_node_name is being used? Is it being used to check for no-op?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants