sarkars/Fix int32-int64 issue. Removing convert op #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayantan-nervana
added
fully reviewed
ready to merge
kanvi-nervana
pushed a commit
that referenced
this pull request
Jan 2, 2020
sayantan-nervana
pushed a commit
that referenced
this pull request
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resizebilinear has a 4d input and a 2d output size.
Making the output size "static" so that it can only be fed by a constant (else a split occurs)
Also removing the "convert" op
Earlier the ngraph function looked like: const(outshape)->convert(i32 to i64)->resizebilinear
now it looks like:
const(outputshape) --> resizebilinear