Skip to content

sarkars/Fix int32-int64 issue. Removing convert op #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2019
Merged

sarkars/Fix int32-int64 issue. Removing convert op #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ngraph_bridge/ngraph_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3735,8 +3735,15 @@ static Status TranslateReshapeOp(
static Status TranslateResizeBilinearOp(
const Node* op, const std::vector<const Tensor*>& static_input_map,
Builder::OpMap& ng_op_map) {
shared_ptr<ng::Node> images, size;
TF_RETURN_IF_ERROR(GetInputNodes(ng_op_map, op, &images, &size));
shared_ptr<ng::Node> images;
TF_RETURN_IF_ERROR(GetInputNodes(ng_op_map, op, &images, nullptr));

std::vector<int32> size_vector;
TF_RETURN_IF_ERROR(
GetStaticInputVector(op, 1, static_input_map, &size_vector));

auto size_int64 = ConstructNgNode<ng::op::Constant>(
op->name(), ngraph::element::i64, ng::Shape{2}, size_vector);

bool align_corners;
TF_RETURN_IF_ERROR(GetNodeAttr(op->attrs(), "align_corners", &align_corners));
Expand All @@ -3751,8 +3758,6 @@ static Status TranslateResizeBilinearOp(
attrs.axes = {1, 2};
// TODO: pads_begin and pads_end are not populated. Check correctness

auto size_int64 =
ConstructNgNode<ng::op::Convert>(op->name(), size, ngraph::element::i64);
SaveNgOp(ng_op_map, op->name(), ConstructNgNode<ng::op::Interpolate>(
op->name(), images, size_int64, attrs));

Expand Down
1 change: 1 addition & 0 deletions ngraph_bridge/ngraph_mark_for_clustering.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,7 @@ Status MarkForClustering(Graph* graph, const std::set<string> skip_these_nodes,
return Status::OK();
};
set_attributes_map["Reshape"] = SetStaticInputs({1});
set_attributes_map["ResizeBilinear"] = SetStaticInputs({1});
set_attributes_map["ScatterNd"] = SetStaticInputs({2});
set_attributes_map["Slice"] = SetStaticInputs({1, 2});
set_attributes_map["Split"] = SetStaticInputs({0});
Expand Down