Shrestha/var in compute #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 2, 2019 12:15
…ensorflow/ngraph-bridge into shrestha/prefetch_right_inputs
shresthamalik
requested review from
kanvi-nervana,
sayantan-nervana and
vishakha-nervana
|
|
||
| // For graphs that were run through AOT | ||
| // Graph rewrite is not done, and there is no entry in catalog | ||
| // If there is not entry in catalog all outputs need to be copied |
added 3 commits
December 18, 2019 16:54
Contributor
sayantan-nervana
left a comment
sayantan-nervana
left a comment
There was a problem hiding this comment.
One minor comment about reusing ng::join
| m_use_parallel_executor = backend->executable_can_create_tensors(); | ||
| #else | ||
| m_use_parallel_executor = false; | ||
| #endif |
Contributor
There was a problem hiding this comment.
note to self: important section here.
| void* dst_ptr = (void*)DMAHelper::base(tf_output_tensors[output_index]); | ||
| ng_outputs[output_index]->read( | ||
| dst_ptr, ng_outputs[output_index]->get_element_count() * | ||
| ng_outputs[output_index]->get_element_type().size()); |
Contributor
There was a problem hiding this comment.
note to self: instead of calling read on everything, call read only on output_indexes_to_be_copied
| ss << val << " "; | ||
| } | ||
| cout << ss.str() << endl; | ||
| } |
Contributor
There was a problem hiding this comment.
there is ng::join. Maybe we don't need this.
cout << title << " " << ng::join(input_vector) << "\n";
vishakha-nervana
approved these changes
Dec 19, 2019
Contributor
vishakha-nervana
left a comment
vishakha-nervana
left a comment
There was a problem hiding this comment.
LGTM, Do we have any c++ test for this use case?
added 7 commits
December 19, 2019 13:38
…ow/ngraph-bridge into shrestha/var_in_compute
kanvi-nervana
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.