Bani / Const Op handling for empty and shorter vector values NGTF-2442 #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/python/test_const.py
Outdated
| log.debug('Invoking sess.run(zz)') | ||
| return sess.run(zz) | ||
|
|
||
| assert ( |
Contributor
There was a problem hiding this comment.
instead of skipping the test we could assert on error being thrown?
ngraph_bridge/ngraph_utils.h
Outdated
| values->resize(n_elements); | ||
|
|
||
| auto val_lastsaved = 0; | ||
| #define SET_VALS(val_size, val_vec) \ |
Contributor
There was a problem hiding this comment.
can we use a templated function instead?
Contributor
Author
There was a problem hiding this comment.
Restructured the code
Contributor
Author
|
@shresthamalik please review the latest changes before merging. |
shresthamalik
deleted the
bani/TranslateConstOp_empty_handling_NGTF-2442
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.