Skip to content

Kanvi/add missing unref #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 10, 2020
Merged

Kanvi/add missing unref #425

merged 5 commits into from
Jan 10, 2020

Conversation

@kanvi-nervana
Copy link
Contributor

@kanvi-nervana kanvi-nervana commented Jan 7, 2020

add the missing unref since a call to Lookup increases the refcount

shresthamalik
shresthamalik approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@shresthamalik shresthamalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sayantan-nervana
sayantan-nervana approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@sayantan-nervana sayantan-nervana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shresthamalik shresthamalik merged commit 0c6bfc8 into master Jan 10, 2020
@shresthamalik shresthamalik deleted the Kanvi/add_missing_unref branch January 10, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@shresthamalik shresthamalik shresthamalik approved these changes

@sayantan-nervana sayantan-nervana sayantan-nervana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fully reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kanvi-nervana @shresthamalik @sayantan-nervana