Skip to content

Kanvi/add missing unref #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 10, 2020
Merged

Kanvi/add missing unref #425

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c49dd4
add the missing unref since a call to Lookup increases the refcount
kanvi-nervana Jan 7, 2020
dd22870
Merge branch 'master' into Kanvi/add_missing_unref
kanvi-nervana Jan 7, 2020
3584524
possible memory leak
Jan 9, 2020
5419af8
Merge branch 'master' into Kanvi/add_missing_unref
Jan 9, 2020
60d7fae
minor
Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ngraph_bridge/ngraph_encapsulate_op_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ Status GetPipelinedIOTensorsReadyForExecution(
get<2>(io_tensors_next_iter)};

if (current_iter_pipeline_depth != (!next_io_tensor_bundle.Id)) {
return errors::Internal("Current Pipeline Depth is ",
current_iter_pipeline_depth,
" and next iter pipeline depth is also ",
next_io_tensor_bundle.Id);
delete shared_data;
return errors::Internal(
"Current Pipeline Depth is ", current_iter_pipeline_depth,
" and next iter pipeline depth is also ", next_io_tensor_bundle.Id);
}

shared_data->AddNextIOTensorBundleForDeviceTransfer(
Expand Down Expand Up @@ -154,6 +154,7 @@ Status GetPipelinedIOTensorsReadyForExecution(
NGRAPH_VLOG(2) << "[PREFETCH] COMPUTE: Using device tensors";
}
shared_data->IncrSkipCount();
shared_data->Unref();
}
}

Expand Down