Fix warnings "target is both a rule and a file" #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel 6.5.0 complains about ``` (04:17:26) WARNING: ..../external/local_config_tf/BUILD:8216:8: target 'libtensorflow_framework.so' is both a rule and a file; please choose another name for the rule (04:17:26) WARNING: ..../external/local_config_tf/BUILD:8226:8: target 'test_log_pb2.py' is both a rule and a file; please choose another name for the rule ``` (Note: I elided the long pathnames in the messages above by replacing them with '....'.) The warnings come from definitions in `third_party/tf/tf_configure.bzl` where the names of a couple of rules are `libtensorflow_framework.so` and `test_log_pb2.py`. Changing the names to `libtensorflow_framework_so` and `test_log_pb2_py` resolves the problem. Other names are possible, of course, but those seem like good choices in order to keep their meanings clear.
MichaelBroughton
approved these changes
Dec 9, 2024
Collaborator
MichaelBroughton
left a comment
MichaelBroughton
left a comment
There was a problem hiding this comment.
I think having the name libtensorflow_framework.so is helpful for static objects that get rolled into the wheel file. I'm not 100% confident that this name change can be done, but lets try it and see if wheel releases break or not :).
Member
Author
|
I didn't make this very clear, but the file names are unchanged (i.e., retain FWIW, I did test the result using TFQ's test (via "bazel test //tensorflow_quantum/..."), after building and installing the TFQ wheel built with these changes into the python virtual environment, and the tests passed. I can do other tests if you have suggestions? |
mhucka
added
kind/bug-report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel 6.5.0 complains about
(Note: I elided the long pathnames in the messages above by replacing them with '....'.) The warnings come from definitions in
third_party/tf/tf_configure.bzlwhere the names of a couple of rules arelibtensorflow_framework.soandtest_log_pb2.py. Changing the names tolibtensorflow_framework_soandtest_log_pb2_pyresolves the problem. Other names are possible, of course, but those seem like good choices in order to keep their meanings clear.