Skip to content

Add Scope::with_kernel_label #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2021
Merged

Add Scope::with_kernel_label #294

merged 3 commits into from
Feb 10, 2021

Conversation

@siyavash
Copy link
Contributor

@siyavash siyavash commented Feb 1, 2021

Implement with_kernel_label for Scope including:

  • Add kernel_label field to Scope.
  • Set the field with Scope::with_kernel_label.
  • Update new_operation to set the corresponding attr.

adamcrume
adamcrume requested changes Feb 7, 2021
View reviewed changes
@siyavash siyavash requested a review from adamcrume February 8, 2021 10:27
@adamcrume adamcrume merged commit fa75a30 into tensorflow:master Feb 10, 2021
@adamcrume
Copy link
Contributor

adamcrume commented Feb 10, 2021

Thanks!

@adamcrume adamcrume mentioned this pull request Feb 10, 2021
Open
ramon-garcia pushed a commit to ramon-garcia/tensorflow-rust that referenced this pull request May 20, 2023
Data Column (tensorflow#294)
e7e907d 
* DataColumn exposes definition and repetition levels. Much stricter check for schema.

* bug fixed (tensorflow#282): FSC understands nulls on non-atomic level

* updating docs

* oops!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamcrume adamcrume Awaiting requested review from adamcrume

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siyavash @adamcrume