Skip to content

RFC: TFLite Support for Node#5

Merged
pyu10055 merged 31 commits into
tensorflow:mainfrom
mattsoulanille:coral-draft-1
Mar 17, 2022
Merged

RFC: TFLite Support for Node#5
pyu10055 merged 31 commits into
tensorflow:mainfrom
mattsoulanille:coral-draft-1

Conversation

@mattsoulanille
Copy link
Copy Markdown
Member

@mattsoulanille mattsoulanille commented Dec 3, 2021

Status Proposed
RFC # 5
Author(s) Matthew Soulanille (msoulanille@google.com), Jason Mayes (jmayes@google.com)
Sponsor Ping Yu (piyu@google.com)
Updated 2021-12-03

Objective

Enable TensorFlow.js to run tflite models in Node and support accelerating those models with a Coral accelerator in a standardized manner agnostic to the form factor of the Coral device.


This change is Reviewable

@mattsoulanille mattsoulanille changed the title RFC: Coral Support for Node RFC: TFLite Support for Node Jan 21, 2022
Copy link
Copy Markdown
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @mattsoulanille and @pyu10055)


rfcs/20211109-tflite-support-for-node.md, line 29 at r8 (raw file):

## Motivation

motivation and user benefit needs to be updated with rationale of provide pluggable delegate interface for tflte binding.

Copy link
Copy Markdown
Member Author

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @pyu10055)


rfcs/20211109-tflite-support-for-node.md, line 29 at r8 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

motivation and user benefit needs to be updated with rationale of provide pluggable delegate interface for tflte binding.

Thanks for the review. I've updated the section to better explain our motivation for adding a pluggable delegate interface.

Copy link
Copy Markdown
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @pyu10055)

Copy link
Copy Markdown
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r6, 1 of 1 files at r10, 1 of 1 files at r11, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mattsoulanille)

@pyu10055 pyu10055 merged commit 1baba8e into tensorflow:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants