This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Minor correction to Imagenette Batcher downloading to indicate directory #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is labeled as such.
Contributor
Author
|
(Verified fix in #341 (comment) , so I merged this in.) |
Contributor
|
Yes, I spent an our debugging the same bug while building the notebook in #338, I should have thought of adding the fix in Datasets as well. Thanks for the fix! |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #328 changed the core downloading function to automatically detect if a download destination was a file or directory. In order for a directory to be detected, it must be labeled as such when constructed, otherwise it will be treated as a file.
This fixes the Batcher pathway in Imagenette to download to a directory named Imagenette, not a file by that name. This should address issue #341.