Comma separated list of log directories is not working anymore with tensorboard==2.0.0 and later

[ReDeiPirati]

Environment information (required)

Diagnostics

Diagnostics output

--- check: autoidentify
INFO: diagnose_tensorboard.py version d515ab103e2b1cfcea2b096187741a0eeb8822ef

--- check: general
INFO: sys.version_info: sys.version_info(major=3, minor=6, micro=9, releaselevel='final', serial=0)
INFO: os.name: posix
INFO: os.uname(): posix.uname_result(sysname='Linux', nodename='32a057dfa970', release='4.9.184-linuxkit', version='#1 SMP Tue Jul 2 22:58:16 UTC 2019', machine='x86_64')
INFO: sys.getwindowsversion(): N/A

--- check: package_management
INFO: has conda-meta: False
INFO: $VIRTUAL_ENV: None

--- check: installed_packages
INFO: installed: tensorboard==2.0.2
INFO: installed: tensorflow==2.0.0
INFO: installed: tensorflow-estimator==2.0.1

--- check: tensorboard_python_version
INFO: tensorboard.version.VERSION: '2.0.2'

--- check: tensorflow_python_version
INFO: generated new fontManager
INFO: tensorflow.__version__: '2.0.0'
INFO: tensorflow.__git_version__: 'v2.0.0-0-g64c3d382ca'

--- check: tensorboard_binary_path
INFO: which tensorboard: b'/usr/local/bin/tensorboard\n'

--- check: addrinfos
socket.has_ipv6 = True
socket.AF_UNSPEC = <AddressFamily.AF_UNSPEC: 0>
socket.SOCK_STREAM = <SocketKind.SOCK_STREAM: 1>
socket.AI_ADDRCONFIG = <AddressInfo.AI_ADDRCONFIG: 32>
socket.AI_PASSIVE = <AddressInfo.AI_PASSIVE: 1>
Loopback flags: <AddressInfo.AI_ADDRCONFIG: 32>
Loopback infos: [(<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 0))]
Wildcard flags: <AddressInfo.AI_PASSIVE: 1>
Wildcard infos: [(<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('0.0.0.0', 0)), (<AddressFamily.AF_INET6: 10>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('::', 0, 0, 0))]

--- check: readable_fqdn
INFO: socket.getfqdn(): '32a057dfa970'

--- check: stat_tensorboardinfo
INFO: directory: /tmp/.tensorboard-info
INFO: .tensorboard-info directory does not exist

--- check: source_trees_without_genfiles
INFO: tensorboard_roots (1): ['/usr/local/lib/python3.6/site-packages']; bad_roots (0): []

--- check: full_pip_freeze
INFO: pip freeze --all:
absl-py==0.8.1
annoy==1.16.2
args==0.1.0
astor==0.8.0
atari-py==0.2.6
attrs==19.3.0
backcall==0.1.0
beautifulsoup4==4.8.2
bleach==3.1.0
blis==0.4.1
boto3==1.11.2
botocore==1.14.2
Bottleneck==1.3.1
box2d-py==2.3.8
cachetools==3.1.1
catalogue==0.0.8
certifi==2019.11.28
chardet==3.0.4
click==6.7
clint==0.5.1
cloudpickle==1.2.2
cycler==0.10.0
cymem==2.0.3
Cython==0.29.14
cytoolz==0.10.1
dataclasses==0.7
decorator==4.4.1
defusedxml==0.6.0
dlib==19.18.0
docutils==0.15.2
entrypoints==0.3
fastai==1.0.60
fastprogress==0.2.2
Flask==1.1.1
floyd-cli==0.11.17
funcsigs==1.0.2
future==0.18.2
gast==0.2.2
google-auth==1.7.2
google-auth-oauthlib==0.4.1
google-pasta==0.1.8
grpcio==1.25.0
gym==0.15.4
gym-retro==0.7.0
h5py==2.10.0
idna==2.8
imageio==2.6.1
importlib-metadata==1.2.0
incremental==17.5.0
ipykernel==5.1.3
ipython==7.10.1
ipython-genutils==0.2.0
ipywidgets==7.5.1
itsdangerous==1.1.0
jedi==0.15.1
jellyfish==0.7.2
Jinja2==2.10.3
jmespath==0.9.4
joblib==0.14.0
json5==0.8.5
jsonschema==3.2.0
jupyter==1.0.0
jupyter-client==5.3.4
jupyter-console==6.0.0
jupyter-core==4.6.1
jupyterlab==1.2.3
jupyterlab-server==1.0.6
kaggle==1.5.6
Keras==2.3.1
Keras-Applications==1.0.8
Keras-Preprocessing==1.1.0
kiwisolver==1.1.0
Markdown==3.1.1
MarkupSafe==1.1.1
marshmallow==2.20.5
matplotlib==3.1.2
menpo==0.9.2
mistune==0.8.4
mock==3.0.5
more-itertools==8.0.0
mpmath==1.1.0
murmurhash==1.0.2
nbconvert==5.6.1
nbformat==4.4.0
networkx==2.4
nltk==3.4.5
notebook==5.6.0
numexpr==2.7.1
numpy==1.17.4
nvidia-ml-py3==7.352.0
oauthlib==3.1.0
opencv-contrib-python==3.4.0.12
opencv-python==4.1.2.30
opt-einsum==3.1.0
packaging==20.0
pandas==0.25.3
pandocfilters==1.4.2
parso==0.5.1
path==13.1.0
path.py==12.4.0
pathlib2==2.3.5
pbr==5.4.4
pexpect==4.7.0
pickleshare==0.7.5
Pillow==6.2.1
pip==19.3.1
plac==1.1.3
plotly==4.3.0
preshed==3.0.2
prometheus-client==0.7.1
prompt-toolkit==2.0.10
protobuf==3.11.1
ptyprocess==0.6.0
pyasn1==0.4.8
pyasn1-modules==0.2.7
pydot==1.4.1
pyemd==0.5.1
pyglet==1.3.2
Pygments==2.5.2
pynvrtc==9.2
PyOpenGL==3.1.4
PyOpenGL-accelerate==3.1.4
pyparsing==2.4.5
Pyphen==0.9.5
pyrsistent==0.15.6
python-dateutil==2.8.1
python-slugify==4.0.0
pytz==2019.3
PyWavelets==1.1.1
PyYAML==5.2
pyzmq==18.1.1
qtconsole==4.6.0
raven==6.10.0
regex==2020.1.8
requests==2.22.0
requests-oauthlib==1.3.0
requests-toolbelt==0.9.1
retrowrapper==0.3.0
retrying==1.3.3
rsa==4.0
s3transfer==0.3.0
sacremoses==0.0.38
scikit-image==0.16.2
scikit-learn==0.22
scikit-umfpack==0.3.2
scipy==1.3.3
seaborn==0.9.0
Send2Trash==1.5.0
sentencepiece==0.1.85
setuptools==42.0.2
six==1.13.0
sklearn==0.0
soupsieve==1.9.5
spacy==2.2.3
srsly==0.2.0
sympy==1.4
tabulate==0.8.6
tensorboard==2.0.2
tensorboardX==2.0
tensorflow==2.0.0
tensorflow-estimator==2.0.1
termcolor==1.1.0
terminado==0.8.3
testpath==0.4.4
text-unidecode==1.3
textacy==0.9.1
thinc==7.3.1
tokenizers==0.1.1
toolz==0.10.0
torch==1.3.1+cpu
torchtext==0.4.0
torchvision==0.4.2+cpu
tornado==6.0.3
tqdm==4.40.0
traitlets==4.3.3
transformers==2.3.0
urllib3==1.24.3
uWSGI==2.0.18
virtualenv==16.7.8
wasabi==0.4.2
wcwidth==0.1.7
webencodings==0.5.1
Werkzeug==0.16.0
wheel==0.33.6
widgetsnbextension==3.5.1
wrapt==1.11.2
xgboost==0.90
zipp==0.6.0
zmq==0.0.0

Issue description

As stated in the title, comma-separated list of log directories is not working anymore with tensorboard==2.0.0 and later. I'm not getting any error, basically, TensorBoard is not able to find the tfevents files.

# Not working
pip install tensorboard==2.0.0  # or later
tensorboard --logdir home:/home,output:/output --host 0.0.0.0

# Working as expected
pip install tensorboard==1.15.0  # or earlier
tensorboard --logdir home:/home,output:/output --host 0.0.0.0

[stephanwlee]

Hi @ReDeiPirati, we made the change because it interfered with a folder with , in the path. As indicated in the help (pasted below for convenience), we now support the legacy mode via logdir_spec.

optional arguments:                                                                                 
  -h, --help            show this help message and exit                                             
  --helpfull            show full help message and exit                                             
  --logdir PATH         Directory where TensorBoard will look to find                               
                        TensorFlow event files that it can display.                                 
                        TensorBoard will recursively walk the directory                             
                        structure rooted at logdir, looking for .*tfevents.*                        
                        files. A leading tilde will be expanded with the                            
                        semantics of Python's os.expanduser function.                               
  --logdir_spec PATH_SPEC                                                                           
                        Like `--logdir`, but with special interpretation for                        
                        commas and colons: commas separate multiple runs,                           
                        where a colon specifies a new name for a run. For                           
                        example: `tensorboard --logdir_spec=name1:/path/to/log                      
                        s/1,name2:/path/to/logs/2`. This flag is discouraged                        
                        and can usually be avoided. TensorBoard walks log                           
                        directories recursively; for finer-grained control,                         
                        prefer using a symlink tree. Some features may not                          
                        work when using `--logdir_spec` instead of `--logdir`. 

[ReDeiPirati]

Hi @stephanwlee,

Thanks for the fast reply and for the help. My bad I didn't check the code, but you should definitively update the README section. If you want/need some help, I can send a PR, let me know.

[stephanwlee]

Ah, thanks for pointing that out. I would definitely appreciate a PR :D