Cleanup: rename globalSettings to persistentSettings #6390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japie1235813
force-pushed
the
renamePersistentSettings
branch
from
d566710 to
b5e78c2
Compare
bmd3k
approved these changes
May 17, 2023
| ); | ||
|
|
||
| // TODO(b/279035032): Removes this function once internal import are renamed. | ||
| export const globalSettingsLoaded = createAction( |
Contributor
There was a problem hiding this comment.
Could you do export const globalSettingsLoaded = persistentSettingsLoaded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
The current action name "globalSettingsLoaded" is actually about persistent settings, rename to make it clear.
Technical description of changes
Still preserves an extra export of "globalSettings" to not break sync and fix everything all at once.