Webapp Angular upgrade 15 to 16#7056
Conversation
…atibility Angular 16. Path updates in libraries and new package.lock
…ons bazel and patchbuild tool
| deps = [ | ||
| "@npm//@babel/core", | ||
| "@npm//@babel/helper-annotate-as-pure", | ||
| + "@npm//@babel/helper-split-export-declaration", |
There was a problem hiding this comment.
Only change in this file. The newer version of @angular-devkit/build-angular: 15.2.11 (resolved in yarn.lock) explicitly added @babel/helper-split-export-declaration as its own dependency. The BUILD.bazel for the optimization scripts can not find it, so needs to be added.
| - if getattr(ctx.attr, "use_angular_plugin", False): | ||
| - closure_js_files.append(ctx.actions.declare_file(basename + ".ngfactory.mjs")) | ||
| - closure_js_files.append(ctx.actions.declare_file(basename + ".ngsummary.mjs")) | ||
| - |
There was a problem hiding this comment.
In this Angular version Ivy is already available so these lines can be removed. @todos resolved.
There was a problem hiding this comment.
Do you think we should try to upgrade @bazel/concatjs to avoid having to maintain this patch file? Low priority -- im fine with this as it is now but it might be sort of kicking a can down the road that we can avoid if we just upgrade.
There was a problem hiding this comment.
Yes, thank you @nattySP , the plan is to upgrade to the latest version of @bazel/concatjs once we migrate to Angular 21. Since we are currently on a transitional version and there is no official compatibility table for this library, patching it was the most efficient temporary solution
There was a problem hiding this comment.
Am I understanding correctly that these lines are present in the standard concatjs 5.7.0 package, and this patch is removing them? (So this TODO is likely removed in a later version of that library?)
Do you know what happens if we don't remove these lines?
There was a problem hiding this comment.
Yes, most probably this will be fixed in newer version of this patch.
If we don't remove these lines, Angular builds can't be done within Bazel. This was one of the issues in the debugging process in the build
| "@npm//:node_modules/zone.js/dist/zone-testing.js", | ||
| "@npm//:node_modules/zone.js/bundles/zone.umd.js", | ||
| "@npm//:node_modules/zone.js/bundles/zone-testing.umd.js", | ||
| "@npm//:node_modules/reflect-metadata/Reflect.js", |
There was a problem hiding this comment.
New paths for zone.js
| * providers: [{ | ||
| * provide: CustomizableButton, | ||
| * useClass: MyCustomButtonComponent, | ||
| * useValue: MyCustomButtonComponent, |
There was a problem hiding this comment.
useValue is an odd configuration for this; useClass would be the expected configuration and i don't expect this to change for an angular version upgrade. What was the reason for this change -- what were the test failures?
There was a problem hiding this comment.
Thank you for pointing this out @nattySP . I forgot to add the justification:
useClasscreates an instance of the component.useValueprovides the class as-is without instantiating it.
CustomizableComponent now expects a class reference so it can create it dynamically itself via viewContainerRef.createComponent().
Triggered by the removal of ComponentFactoryResolver in Angular 16, which had been deprecated since Angular 13.
There was a problem hiding this comment.
Thank you so much for the explanation, makes sense! I missed that createComponent() was being used.
…brary. Fix will be applied in internal build
| - if getattr(ctx.attr, "use_angular_plugin", False): | ||
| - closure_js_files.append(ctx.actions.declare_file(basename + ".ngfactory.mjs")) | ||
| - closure_js_files.append(ctx.actions.declare_file(basename + ".ngsummary.mjs")) | ||
| - |
There was a problem hiding this comment.
Am I understanding correctly that these lines are present in the standard concatjs 5.7.0 package, and this patch is removing them? (So this TODO is likely removed in a later version of that library?)
Do you know what happens if we don't remove these lines?
tensorflow#7057) ## Motivation for features / changes Fixes tensorflow#7003. `pkg_resources` is removed in newer setuptools, which can break TensorBoard at import/runtime. This change removes runtime reliance on `pkg_resources` in the two affected code paths. ## Technical description of changes - Replaced dynamic plugin discovery in `tensorboard/default.py`: - from `pkg_resources.iter_entry_points(...)` - to `importlib.metadata.entry_points(...)` with compatibility handling for different Python return shapes. - Replaced version parsing in `tensorboard/data/server_ingester.py`: - from `pkg_resources.parse_version(...)` - to `packaging.version.parse(...)`. - Updated related tests: - `tensorboard/default_test.py` now patches `_iter_entry_points` and uses `load()`-style fake entry points. - `tensorboard/version_test.py` now validates PEP 440 behavior using `packaging.version`. - Updated Bazel deps to use `expect_packaging_installed` where `packaging` is now required. ## Detailed steps to verify changes work correctly (as executed by you) Executed locally in an isolated venv: - `python -m py_compile tensorboard/default.py tensorboard/default_test.py tensorboard/data/server_ingester.py tensorboard/version_test.py` - `PYTHONPATH=. python tensorboard/version_test.py` (passes) Attempted but environment-limited locally: - `bazel test //tensorboard:version_test //tensorboard:default_test //tensorboard/data:server_ingester_test` (bazel not available in local shell) - Direct execution of `default_test.py` and `server_ingester_test.py` without Bazel-generated artifacts hit local environment/import constraints. ## Alternate designs / implementations considered (or N/A) - N/A
…atibility Angular 16. Path updates in libraries and new package.lock
…ons bazel and patchbuild tool
…brary. Fix will be applied in internal build
…rd into feature/upgrade15-16
4 participants
Motivation for features / changes
This PR is the first step in a planned major Angular upgrade cycle, where each major version will be delivered in a separate PR, incrementally progressing until the project reaches Angular 20.
This specific PR upgrades TensorBoard from Angular 15 to Angular 16, initiating the migration path toward Angular 20+.
Keeping the framework and aligned dependencies (NgRx, TypeScript, RxJS, zone.js, etc.) up to date ensures continued compatibility, security support, and maintainability, while preparing the project for future Angular features and ecosystem improvements.
Technical description of changes
Upgrade the TensorBoard web application from Angular 15 to Angular 16 following TensorBoard’s DEVELOPMENT.md guidelines and the official Angular migration guide.
Detailed steps to verify changes work correctly (as executed by you)