Skip to content

[SE] Include absl/memory/memory.h#42942

Merged
tensorflow-copybara merged 1 commit intotensorflow:masterfrom
SaveTheRbtz:absl_include
Sep 6, 2020
Merged

[SE] Include absl/memory/memory.h#42942
tensorflow-copybara merged 1 commit intotensorflow:masterfrom
SaveTheRbtz:absl_include

Conversation

@SaveTheRbtz
Copy link
Contributor

Otherwise our build environment fails to build it with:

external/org_tensorflow/tensorflow/stream_executor/host/host_platform.cc: In member function 'virtual stream_executor::port::StatusOr<std::unique_ptr<stream_executor::StreamExecutor> > stream_executor::host::HostPlatform::GetUncachedExecutor(const stream_executor::StreamExecutorConfig&)':
external/org_tensorflow/tensorflow/stream_executor/host/host_platform.cc:73:25: error: 'make_unique' is not a member of 'absl'
   auto executor = absl::make_unique<StreamExecutor>(
                         ^~~~~~~~~~~

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Sep 4, 2020
@gbaned gbaned self-assigned this Sep 4, 2020
@gbaned gbaned requested a review from timshen91 September 4, 2020 02:38
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 4, 2020
@tensorflow-copybara tensorflow-copybara merged commit de8ecf4 into tensorflow:master Sep 6, 2020
@SaveTheRbtz SaveTheRbtz deleted the absl_include branch September 6, 2020 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants