[INTEL MKL] Refactoring code related to compiling oneDNN with threadpool. #47279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penpornk
requested changes
Feb 26, 2021
Member
penpornk
left a comment
penpornk
left a comment
There was a problem hiding this comment.
@cuixiaom Thank you for the heads up!
@agramesh1 Sorry for the delay! I thought this one was not urgent based on the title. I have a few nits.
Co-authored-by: Penporn Koanantakool <38085909+penpornk@users.noreply.github.com>
Co-authored-by: Penporn Koanantakool <38085909+penpornk@users.noreply.github.com>
penpornk
approved these changes
Feb 27, 2021
Member
penpornk
left a comment
penpornk
left a comment
There was a problem hiding this comment.
Thank you and have a great weekend! :)
google-ml-butler
bot
added
kokoro:force-run
Contributor
Author
@penpornk thanks. There was a conflict I resolved just after you approved. Not sure if the changes registered before the testing started. |
penpornk
approved these changes
Feb 27, 2021
Member
penpornk
left a comment
penpornk
left a comment
There was a problem hiding this comment.
I see. Approving again then. :)
google-ml-butler
bot
added
kokoro:force-run
penpornk
approved these changes
Mar 2, 2021
google-ml-butler
bot
added
kokoro:force-run
Contributor
Author
|
@penpornk thanks for approving again. |
Contributor
Author
|
Hi @penpornk The internal Google checks failed for this PR, can you provide the logs for the failures? |
Member
|
@agramesh1 Thank you for the heads up! I'll fix this internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring code to replace the macro ENABLE_MKLDNN_THREADPOOL with ENABLE_ONEDNN_OPENMP. Now, the oneDNN based kernels will be compiled to use Eigen threadpool by default unless ENABLE_ONEDNN_OPENMP is defined. PR also includes some minor cleanup to remove unused mkl_opensource build option.