[r2.5 port][ROCm] Port PR 47980 to r2.5 #48444
Merged
mihaimaruseac merged 2 commits intotensorflow:r2.5from Apr 22, 2021
Merged
[r2.5 port][ROCm] Port PR 47980 to r2.5 #48444mihaimaruseac merged 2 commits intotensorflow:r2.5from
mihaimaruseac merged 2 commits intotensorflow:r2.5from
Conversation
The following commit adds GPU support for int32/int64 support for the Unique/UniqueWithCounts ops, but breaks ROCm build in the process tensorflow@02585ac ``` tensorflow/core/kernels/unique_op_gpu.cu.cc:292:9: error: no matching constructor for initialization of 'gpuprim::TransformInputIterator<int, SegmentIndicatorFunctor<unsigned long, int>, gpuprim::CountingInputIterator<int>>' (aka 'transform_iterator<rocprim::counting_iterator<int, long>, tensorflow::(anonymous namespace)::SegmentIndicatorFunctor<unsigned long, int>, int>') segment_indicator_iter(0, {sorted_input_ptr}); ^ ~~~~~~~~~~~~~~~~~~~~~ tensorflow/core/kernels/unique_op_gpu.cu.cc:176:12: note: in instantiation of member function 'tensorflow::UniqueOpGPU<unsigned long, int>::ComputeAsync' requested here explicit UniqueOpGPU(OpKernelConstruction* context) ^ tensorflow/core/kernels/unique_op_gpu.cu.cc:461:27: note: in instantiation of member function 'tensorflow::UniqueOpGPU<unsigned long, int>::UniqueOpGPU' requested here TF_CALL_REAL_NUMBER_TYPES(REGISTER_UNIQUE_GPU); ``` This PR/commit disables ROCm support for newly added ops to get the CSB passing again. We are looking into resolving the build errors, and will file a separate PR to re-enable ROCm functionality for the same. This PR commit also adds the `no_rocm` tag to a couple of unit tests that start failing as a consequence of lack of ROCm support for these ops. ``` //tensorflow/python/keras/optimizer_v2:adamax_test_gpu FAILED in 3 out of 3 in 7.0s //tensorflow/python/training:adam_test_gpu FAILED in 3 out of 3 in 6.3s ```
…m platform tensorflow@50f8897 ``` //tensorflow/python/keras/distribute:dataset_creator_model_fit_test_gpu FAILED in 3 out of 3 in 112.5s ``` This commit adds a `no_rocm` tag to temporarily disable that unit-test on ROCm.
mihaimaruseac
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @mihaimaruseac @angerson
#47980