[r2.5] Update of oneDNN version for mkl_aarch64 build target#48543
[r2.5] Update of oneDNN version for mkl_aarch64 build target#48543mihaimaruseac merged 2 commits intotensorflow:r2.5from
Conversation
|
@penpornk @agramesh1 please have a look. |
|
@alenik01 Oh, I thought you are going to upgrade this in master and not 2.5. For 2.5, I'm not sure if we can cherry-pick this, since cherry-picks are for security / bug fixes. Upgrading from a v2.1 release to v2.2 release might count more towards adding features rather than fixes. (The upgrade we did here was from a random commit after @mihaimaruseac What do you think? |
Co-authored-by: Penporn Koanantakool <38085909+penpornk@users.noreply.github.com>
|
@penpornk if it is possible to cherry-pick this for v2.5 release, then it would be nice (the problem was that oneDNN v2.2 had been released after TF feature freeze deadline). If not, then this PR can be merged in the master. |
|
@alenik01 Could you please share how much performance improvements you observe from this update? Is this update for performance improvements alone or is it also fixing some issues? |
|
@alenik01 Also, could you please create another PR for the I will check with the team if this PR is eligible for cherry-picking when I hear back about the speedups and whether this fixes any issues as well. Thank you! |
The speedup is noticeable, x1.7 (was measure for ResNet50 inference).
Performance alone.
OK, I will create one.
Many thanks for clarifying, now I understand that the version update for |
|
@mihaimaruseac - this is the PR we briefly discussed at the SIG build meeting the other week. |
This PR noticeably improves the performance of CNNs on AArch64 (
--config=mkl_aarch64). oneDNN version upgrade follows the PR #48035