Fix tf.io.decode_raw bugs and update documentation.#49095
Merged
mihaimaruseac merged 1 commit intotensorflow:r2.5from May 11, 2021
Merged
Fix tf.io.decode_raw bugs and update documentation.#49095mihaimaruseac merged 1 commit intotensorflow:r2.5from
tf.io.decode_raw bugs and update documentation.#49095mihaimaruseac merged 1 commit intotensorflow:r2.5from
Conversation
Fixes cases where specifying `fixed_length` resulted in data loss and even segfault and corruption of the Python interpreter. The fix is subtle but needed due to pointer arithmetic rules. Makes sure that `fixed_length` does not change the output when present but not needed. Eliminates needless copy and cast in the main codepath. PiperOrigin-RevId: 371322725 Change-Id: I514ef67a2961c86422f69d05122d31615e87896c
mihaimaruseac
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cases where specifying
fixed_lengthresulted in data loss and even segfault and corruption of the Python interpreter. The fix is subtle but needed due to pointer arithmetic rules.Makes sure that
fixed_lengthdoes not change the output when present but not needed.Eliminates needless copy and cast in the main codepath.
PiperOrigin-RevId: 371322725
Change-Id: I514ef67a2961c86422f69d05122d31615e87896c