Correct use of StringRef and ArrayRef#53167
Merged
copybara-service[bot] merged 1 commit intotensorflow:masterfrom Dec 22, 2021
Merged
Correct use of StringRef and ArrayRef#53167copybara-service[bot] merged 1 commit intotensorflow:masterfrom
copybara-service[bot] merged 1 commit intotensorflow:masterfrom
Conversation
elfringham
force-pushed
the
core-ir-test-fix
branch
from
3ce0b94 to
70de5ef
Compare
rdzhabarov
suggested changes
Dec 16, 2021
elfringham
force-pushed
the
core-ir-test-fix
branch
from
70de5ef to
5c14811
Compare
Contributor
Author
|
Build of master was broken when the checks were run. The failure comes from that reason and is not due to this commit. |
mihaimaruseac
approved these changes
Dec 21, 2021
google-ml-butler
Bot
added
kokoro:force-run
rdzhabarov
approved these changes
Dec 22, 2021
mihaimaruseac
approved these changes
Dec 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current code takes a reference to transient objects which go out of scope and get overwritten. This renders the references taken invalid and leads to incorrect operation and possible SIGSEGV.
The objects referred to by StringRef and ArrayRef need to have their own independent lifetime.
Fixes #53166