Skip to content

[TF-TRT] Disable combined_nms_test with no_oss tag.#56823

Merged
copybara-service[bot] merged 1 commit intotensorflow:masterfrom
nluehr:oss_disable_nms_test
Jul 21, 2022
Merged

[TF-TRT] Disable combined_nms_test with no_oss tag.#56823
copybara-service[bot] merged 1 commit intotensorflow:masterfrom
nluehr:oss_disable_nms_test

Conversation

@nluehr
Copy link
Contributor

@nluehr nluehr commented Jul 19, 2022

The combined_nms_test has long failed under TensorRT 8.x. I'm not sure the test was every reliably passing.

I'm disabling it in OSS the tests in anticipation of updating OSS builds from TensorRT 7.2 to TensorRT 8.4 (c.f., tensorflow/build#124)

Attn: @bixia1

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 19, 2022
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Jul 20, 2022
@gbaned gbaned requested a review from bixia1 July 20, 2022 04:48
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jul 20, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 20, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 20, 2022
@copybara-service copybara-service bot merged commit 28bad43 into tensorflow:master Jul 21, 2022
@nluehr nluehr deleted the oss_disable_nms_test branch July 27, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review Pull request awaiting review comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:XS CL Change Size: Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants