Replay of #8637: Add the corresponding --action_env to .bazelrc from …#8812
Merged
martinwicke merged 1 commit intotensorflow:masterfrom Mar 29, 2017
Merged
Replay of #8637: Add the corresponding --action_env to .bazelrc from …#8812martinwicke merged 1 commit intotensorflow:masterfrom
martinwicke merged 1 commit intotensorflow:masterfrom
Conversation
…elrc from ./configure The original PR got overriden by bc456e3 This will make the fetch phase reproducible so the refetch does not happens unless people re-run configure (the environment variable are stored in the .bazelrc file). Fixes tensorflow#8619.
martinwicke
approved these changes
Mar 29, 2017
Member
Contributor
Author
|
Humm maybe I got the commit wrong...
…On Wed, Mar 29, 2017, 9:58 PM Martin Wicke ***@***.***> wrote:
Merged #8812 <#8812>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8812 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADjHf2N0nzxdn32KGVyi0rrgUTsus39Iks5rqrfQgaJpZM4MtS5J>
.
|
Member
|
Anyway, we're looking into this squashing problem. There's probably bad UX
in the merging process which encourages this type of problem.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…./configure
The original PR got overriden by bc456e3
This will make the fetch phase reproducible so the refetch does
not happens unless people re-run configure (the environment variable
are stored in the .bazelrc file).
Fixes #8619.