tensorflow.bzl: strip bazel version number to work with patch bazel release #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elease The newest bazel version number is 0.2.2b, when need to strip 2b
|
Can one of the admins verify this patch? |
tensorflow/tensorflow.bzl
Outdated
| version_tuple = () | ||
| for number in parts[0].split('.'): | ||
| version_tuple += (int(number),) | ||
| version_tuple += (int(number.strip('abcdefghij')),) |
There was a problem hiding this comment.
can you replace 'int' with 'str' here ?
version_tuple += (str(number),)
We'll compare strings lexicographically, which will probably solve your problem here.
Ideally we'd all use semantic versioning conventions though.
The newest bazel version is 0.2.2b, which makes int('2b') not working anymore.
|
There are probably better ways to do this, but in the interest of unbreaking people, this seems fine. Going to test and merge if successful. |
|
@tensorflow-jenkins test this please |
|
hurray |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest bazel version number is 0.2.2b, when need to strip 2b