Skip to content

Support NHWC for Tensor_Float_32 + Ampere GPUs #55761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2022
Merged

Support NHWC for Tensor_Float_32 + Ampere GPUs #55761

merged 3 commits into from
Jul 11, 2022

Conversation

@kaixih
Copy link
Contributor

@kaixih kaixih commented Apr 26, 2022

To better utilize the Tensor Cores of TF32 dtype on Ampere GPUs, NHWC data format is recommended. This PR allows the grappler layout optimizer to enforce a target=NHWC optimization when TF32 + Ampere is detected.

cc. @nluehr

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Apr 26, 2022
@tilakrayal tilakrayal requested a review from penpornk April 27, 2022 06:26
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Apr 27, 2022
@gbaned gbaned requested review from ezhulenev and removed request for penpornk April 28, 2022 07:30
@gbaned gbaned added the comp:grappler Grappler related issues label Apr 28, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 28, 2022
@kaixih kaixih mentioned this pull request Apr 30, 2022
Merged
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Apr 30, 2022
@gbaned gbaned added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels May 2, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 2, 2022
@kaixih kaixih mentioned this pull request May 4, 2022
Merged
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels May 13, 2022
@kaixih kaixih added the kokoro:force-run Tests on submitted change label May 24, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 24, 2022
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Jun 15, 2022
@kaixih kaixih force-pushed the ampere_tf32_upstream branch from 73dfe5c to 128210d Compare June 15, 2022 22:10
@kaixih kaixih force-pushed the ampere_tf32_upstream branch from 128210d to 82288a0 Compare June 15, 2022 22:14
@kaixih
Copy link
Contributor Author

kaixih commented Jun 16, 2022

@reedwm Can you please take a look at if the linking issue is resolved?

@gbaned gbaned requested a review from reedwm June 16, 2022 14:34
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jun 16, 2022
@kaixih
Copy link
Contributor Author

kaixih commented Jun 17, 2022

Gentle ping @reedwm .

@gbaned gbaned requested a review from ezhulenev June 20, 2022 15:31
@kaixih kaixih added the kokoro:force-run Tests on submitted change label Jun 23, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 23, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 29, 2022
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Jun 29, 2022
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Jul 1, 2022
@gbaned gbaned added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jul 1, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 1, 2022
@gcforster gcforster added the kokoro:force-run Tests on submitted change label Jul 6, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 6, 2022
@gcforster gcforster self-requested a review July 8, 2022 00:00
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jul 8, 2022
gcforster
gcforster approved these changes Jul 8, 2022
View reviewed changes
Copy link

@gcforster gcforster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Jul 8, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 8, 2022
@gcforster gcforster added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Jul 8, 2022
@copybara-service copybara-service bot merged commit 79e24d5 into tensorflow:master Jul 11, 2022
kaixih added a commit to kaixih/tensorflow that referenced this pull request Jul 12, 2022
@kaixih
Revert "Merge pull request tensorflow#55761 from kaixih:ampere_tf32_u…
6c8c01a 
…pstream"

This reverts commit 79e24d5, reversing
changes made to 1120180.
@kaixih kaixih mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezhulenev ezhulenev Awaiting requested review from ezhulenev

2 more reviewers

@reedwm reedwm reedwm approved these changes

@gcforster gcforster gcforster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gbaned gbaned

Labels

comp:grappler Grappler related issues ready to pull PR ready for merge process size:M CL Change Size: Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kaixih @ezhulenev @reedwm @gcforster @kokoro-team @tensorflowbutler @gbaned