Skip to content

[Intel oneDNN] Enhancing the Pattern Matcher #56339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2022
Merged

[Intel oneDNN] Enhancing the Pattern Matcher #56339

merged 1 commit into from
Jun 10, 2022

Conversation

othakkar
Copy link
Contributor

@othakkar othakkar commented Jun 3, 2022

The following is a summary of the changes implemented in this PR:

  • Condition check for swapping: The patterns with first input as "*" is currently being rejected by the pattern matcher. The reason for this is that lines 126-127 (condition check for swapping the pattern) only consider the first input of the Op in the graph. In order to make it more comprehensive and avoid the aforementioned issue, similar checks have been added for the second input of the Op in the graph.
  • IsSame(...) and IsCommutative(...) functions: The functions are not currently equipped to handle a pattern expressing an op among multiple op types (separated by "|"). Implemented changes to facilitate that.
  • Also, this PR adds SquaredDifference and Maximum to the list of commutative ops.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jun 3, 2022
@github-actions github-actions bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 3, 2022
@gbaned gbaned added the comp:grappler Grappler related issues label Jun 3, 2022
@gbaned gbaned requested a review from rmlarsen June 3, 2022 07:59
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jun 3, 2022
@othakkar othakkar changed the title Enhancing the Pattern Matcher [Intel oneDNN] Enhancing the Pattern Matcher Jun 3, 2022
rmlarsen
rmlarsen requested changes Jun 3, 2022
View reviewed changes
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Jun 6, 2022
@othakkar othakkar mentioned this pull request Jun 6, 2022
Merged
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Jun 9, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 9, 2022
@copybara-service copybara-service bot merged commit 65dd79a into tensorflow:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmlarsen rmlarsen rmlarsen approved these changes

Assignees

@nitins17 nitins17

@penpornk penpornk

@gbaned gbaned

@learning-to-play learning-to-play

Labels

comp:grappler Grappler related issues ready to pull PR ready for merge process size:S CL Change Size: Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@othakkar @rmlarsen @kokoro-team @tensorflowbutler @nitins17 @penpornk @gbaned @learning-to-play