Various Google C++ style guide fixes #57985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for string, <vector> for vector
…> for move, <algorithm> for max
… for string, <vector> for vector
mihaimaruseac
approved these changes
Dec 29, 2022
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to contribute to this wonderful project and picked up some low hanging fruit in the C++ section.
I found some inconsistencies with the style guide on some files, and therefore submitted this PR.
Specifically, I have edited some files so that they comply to the "include what you use" rule (https://google.github.io/styleguide/cppguide.html#Include_What_You_Use) from the style guide.