Skip to content

Upgrading to the latest oneDNN 2.7.1 #58269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

Upgrading to the latest oneDNN 2.7.1 #58269

merged 1 commit into from
Oct 24, 2022

Conversation

ashiqimranintel
Copy link
Contributor

Upgrading to the latest oneDNN 2.7.1

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Oct 23, 2022
@github-actions github-actions bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 24, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 24, 2022
@ashiqimranintel
Copy link
Contributor Author

@penpornk , can you approve this PR?

penpornk
penpornk approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Oct 24, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 24, 2022
penpornk
penpornk reviewed Oct 24, 2022
View reviewed changes
third_party/mkl_dnn/mkldnn_v1.BUILD
"-UUSE_MKL",
"-UUSE_CBLAS",
"-DDNNL_ENABLE_MAX_CPU_ISA",
"-DDNNL_DISABLE_PRIMITIVE_CACHE",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashiqimranintel This is intentional, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @penpornk yes. This reverts a change in 2.10 #57071 due to a mem corruption that is now fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agramesh1 Thank you for the quick reply!

@penpornk
Copy link
Member

ARM CI failed, but it seems to be an existing failure since another run before it (from another PR) also got the same failure.

@ashiqimranintel
Copy link
Contributor Author

@penpornk , I think it's unrelated

copybara-service bot pushed a commit to google/tsl that referenced this pull request Oct 24, 2022
@ashiqimranintel @copybara-github
PR #58269: Upgrading to the latest oneDNN 2.7.1
35f218d 
Imported from GitHub PR tensorflow/tensorflow#58269

Upgrading to the latest oneDNN 2.7.1
Copybara import of the project:

--
edc9daa34a18d5029b6ff66f0edc3c738bb87e8d by Ashiq Imran <ashiq.imran@intel.com>:

Upgrading to the latest oneDNN 2.7.1

Merging this change closes #58269

PiperOrigin-RevId: 483448907
@copybara-service copybara-service bot merged commit ad5af70 into tensorflow:master Oct 24, 2022
@huiyan2021 huiyan2021 mentioned this pull request Oct 25, 2022
Closed
@penpornk penpornk mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penpornk penpornk penpornk approved these changes

+1 more reviewer

@agramesh1 agramesh1 agramesh1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@penpornk penpornk

@gbaned gbaned

Labels

ready to pull PR ready for merge process size:S CL Change Size: Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ashiqimranintel @penpornk @agramesh1 @kokoro-team @gbaned