Skip to content

Don't link tensorflow-lite against gemmlowp #58678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

Don't link tensorflow-lite against gemmlowp #58678

merged 1 commit into from
Mar 15, 2023

Conversation

jameshilliard
Copy link
Contributor

We can't link against gemmlowp as it is a header only library.

Fixes:

/bin/ld: cannot find -lgemmlowp: No such file or directory

@jameshilliard
Don't link tensorflow-lite against gemmlowp
fb58458 
We can't link against gemmlowp as it is a header only library.

Fixes:
/bin/ld: cannot find -lgemmlowp: No such file or directory
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Nov 24, 2022
@gbaned gbaned added the comp:lite TF Lite related issues label Nov 25, 2022
@gbaned gbaned requested a review from terryheo November 25, 2022 11:14
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Nov 25, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 29, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 29, 2022
@jameshilliard
Copy link
Contributor Author

Anything holding this up from being merged? I see a Google internal checks FAILED for runs with create time 2022-12-30T16:36:16.327881750Z. test failure but there aren't any failure details visible.

@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jan 6, 2023
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process awaiting review Pull request awaiting review labels Jan 17, 2023
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jan 25, 2023
@gbaned gbaned added ready to pull PR ready for merge process kokoro:force-run Tests on submitted change and removed ready to pull PR ready for merge process labels Feb 9, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 14, 2023
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 1, 2023
@copybara-service copybara-service bot merged commit a692ff7 into tensorflow:master Mar 15, 2023
@terryheo
Copy link
Member

The PR had a regression and I fixed it and merged.
a692ff7

@qukhan qukhan mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@terryheo terryheo Awaiting requested review from terryheo

Assignees

@gbaned gbaned

Labels

comp:lite TF Lite related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jameshilliard @terryheo @mihaimaruseac @kokoro-team @gbaned