Remove dependency on simple_console_for_windows #61619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaimaruseac
approved these changes
Aug 18, 2023
google-ml-butler
bot
added
kokoro:force-run
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Aug 18, 2023
Imported from GitHub PR tensorflow/tensorflow#61619 This is one way of getting around the problem where TF is too big to build on Windows. If bazel is told to create the runfiles symlink tree explicitly, Windows can use the same method as Linux to build the pip package without needing to zip everything up, and simple_console_for_windows is no longer needed. The caveats are: - The MSYS2 environment may need to be configured specifically to support symlinks; I am not sure. I set my test environment to use `MSYS=winsymlinks:nativestrict` but didn't test this solution without that. - The build environment needs `rsync`, which replaces `cp` in one case where `cp` was giving me symlink-related errors. I extracted this out of a work-in-progress environment I've been exploring, so I'm not 100% sure it will work right... but it seems very promising. Copybara import of the project: -- 93596226a7df33dd085712d4bed9f66ee1b55e27 by Austin Anderson <angerson@google.com>: Remove dependency on simple_console_for_windows Merging this change closes #61619 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61619 from angerson:master 93596226a7df33dd085712d4bed9f66ee1b55e27 PiperOrigin-RevId: 558131327
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Aug 18, 2023
Imported from GitHub PR tensorflow/tensorflow#61619 This is one way of getting around the problem where TF is too big to build on Windows. If bazel is told to create the runfiles symlink tree explicitly, Windows can use the same method as Linux to build the pip package without needing to zip everything up, and simple_console_for_windows is no longer needed. The caveats are: - The MSYS2 environment may need to be configured specifically to support symlinks; I am not sure. I set my test environment to use `MSYS=winsymlinks:nativestrict` but didn't test this solution without that. - The build environment needs `rsync`, which replaces `cp` in one case where `cp` was giving me symlink-related errors. I extracted this out of a work-in-progress environment I've been exploring, so I'm not 100% sure it will work right... but it seems very promising. Copybara import of the project: -- 93596226a7df33dd085712d4bed9f66ee1b55e27 by Austin Anderson <angerson@google.com>: Remove dependency on simple_console_for_windows Merging this change closes #61619 PiperOrigin-RevId: 558183664
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
PiperOrigin-RevId: 558183664
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Aug 18, 2023
Imported from GitHub PR tensorflow/tensorflow#61619 This is one way of getting around the problem where TF is too big to build on Windows. If bazel is told to create the runfiles symlink tree explicitly, Windows can use the same method as Linux to build the pip package without needing to zip everything up, and simple_console_for_windows is no longer needed. The caveats are: - The MSYS2 environment may need to be configured specifically to support symlinks; I am not sure. I set my test environment to use `MSYS=winsymlinks:nativestrict` but didn't test this solution without that. - The build environment needs `rsync`, which replaces `cp` in one case where `cp` was giving me symlink-related errors. I extracted this out of a work-in-progress environment I've been exploring, so I'm not 100% sure it will work right... but it seems very promising. Copybara import of the project: -- 93596226a7df33dd085712d4bed9f66ee1b55e27 by Austin Anderson <angerson@google.com>: Remove dependency on simple_console_for_windows Merging this change closes #61619 PiperOrigin-RevId: 558183664
|
Hi @angerson and @mihaimaruseac thank you for the PR. It is working well, wheels are generated successfully and sanity tests are passing. |
mihaimaruseac
approved these changes
Aug 19, 2023
google-ml-butler
bot
added
kokoro:force-run
|
Thank you for confirming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way of getting around the problem where TF is too big to build on Windows. If bazel is told to create the runfiles symlink tree explicitly, Windows can use the same method as Linux to build the pip package without needing to zip everything up, and simple_console_for_windows is no longer needed.
The caveats are:
MSYS=winsymlinks:nativestrictbut didn't test this solution without that.rsync, which replacescpin one case wherecpwas giving me symlink-related errors.I extracted this out of a work-in-progress environment I've been exploring, so I'm not 100% sure it will work right... but it seems very promising.