Always propagate shardings along the batch dimension in InferConvolutionShardingFromOperands.
#63319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_614049496
branch
2 times, most recently
from
41e0214 to
ba2b116
Compare
…tionShardingFromOperands`. Before this cl, if the kernel is large, we replicate the output, even along the batch dimension. This cl enables the sharding propagation between lhs and output along the batch dimension such that we can support data parallelism. Add a test case, which fails before this cl and succeeds with this cl. PiperOrigin-RevId: 614738671
copybara-service
bot
force-pushed
the
test_614049496
branch
from
ba2b116 to
b219bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always propagate shardings along the batch dimension in
InferConvolutionShardingFromOperands.Before this cl, if the kernel is large, we replicate the output, even along the batch dimension. This cl enables the sharding propagation between lhs and output along the batch dimension such that we can support data parallelism.
Add a test case, which fails before this cl and succeeds with this cl.