Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Conversation

@cacfd3a
Copy link

@cacfd3a cacfd3a commented Sep 27, 2017

See also #153. Same commits except for the ~2000 rune images. I made a new branch so that the images don't clutter the git history .

was asked to write a tutorial for adding a data set to the model builder. hope you like it


This change is Reviewable

@cacfd3a cacfd3a changed the title Rune recognition tutorial without images Example: add a dataset to the model builder (Rune recognition) Sep 27, 2017
@nsthorat
Copy link
Contributor

nsthorat commented Oct 1, 2017

This tutorial is fantastic, thank you for putting the effort in. Will merge after these tiny comments :)


Review status: 0 of 4 files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.


demos/rune_recognition/generate_train_examples_runes.html, line 93 at r1 (raw file):

  function clearCanvas() {
    ctx.clearRect(0, 0, 320, 320);
    // document.getElementById("canvasimg").style.display = "none";

remove this line


demos/rune_recognition/generate_train_examples_runes.html, line 150 at r1 (raw file):

      charIndex = (charIndex + 1) % allChars.length;
    }
    console.log("setting char " + charIndex);

remove this


demos/rune_recognition/rune_recognition.md, line 8 at r1 (raw file):

# Example: Add a new data set to the model builder demo

In this tutorial we add a data set to the [model builder demo](https://pair-code.github.io/deeplearnjs/demos/model-builder/model-builder-demo.html) and train a neural network that can recognize individual glyphs of runes. It is similar to the canonical [MNIST example](https://www.tensorflow.org/get_started/mnist/pros) for recognizing handwritten digits, but with a different alphabet. This tutorial is meant as a minimal scaffold to start off your adventures in deep learning.

link to deeplearnjs.org now instead of the old base URL


demos/rune_recognition/rune_recognition.md, line 150 at r1 (raw file):

## Modify model builder demo

(See also the [development pointers](https://pair-code.github.io/deeplearnjs/#development))

link to deeplearnjs.org now instead of the old base URL


demos/rune_recognition/rune_recognition.md, line 154 at r1 (raw file):

First we verify that we can run the model builder. From the project root, run:

* `npm install`

can you make this "npm run prep", we need to install bower components for the model builder to work too


Comments from Reviewable

@cacfd3a
Copy link
Author

cacfd3a commented Oct 2, 2017

Thank you! I've processed the feedback.

@nsthorat
Copy link
Contributor

nsthorat commented Oct 2, 2017

:lgtm_strong:


Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@nsthorat nsthorat merged commit 8dcc13b into tensorflow:master Oct 2, 2017
mnottheone pushed a commit to mnottheone/deeplearnjs that referenced this pull request Dec 1, 2018
…rflow#156)

* Create generate_train_examples_runes.html

* Change styling

Is it okay if we link the font from an external or should we include it in the repo? It's licensed under the [open font license](http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=OFL) by the way.

* Create generate_rune_data_for_model_builder.py

* Add files via upload

* Create rune_recognition.md

* Update rune_recognition.md

* Update rune_recognition.md

* Update rune_recognition.md

* Update rune_recognition.md

* Create deleteme.md

* Update rune_recognition.md

* Update rune_recognition.md

* Update rune_recognition.md

* Minor text update

(cherry picked from commit e2b4f01)

* Runeless tutorial

* Update text on where to find rune images

* Merge branch 'master' into rune_recognition_tutorial_without_images

* Use single quotes everywhere

* Note that number of labels is different for runes than for MNIST

* Merge branch 'master' into rune_recognition_tutorial_without_images

* Update generate_train_examples_runes.html

* Update rune_recognition.md

* Merge branch 'master' into rune_recognition_tutorial_without_images
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants