-
Notifications
You must be signed in to change notification settings - Fork 941
Example: add a dataset to the model builder (Rune recognition) #156
Example: add a dataset to the model builder (Rune recognition) #156
Conversation
Is it okay if we link the font from an external or should we include it in the repo? It's licensed under the [open font license](http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=OFL) by the way.
(cherry picked from commit e2b4f01)
|
This tutorial is fantastic, thank you for putting the effort in. Will merge after these tiny comments :) Review status: 0 of 4 files reviewed at latest revision, 5 unresolved discussions, some commit checks failed. demos/rune_recognition/generate_train_examples_runes.html, line 93 at r1 (raw file):
remove this line demos/rune_recognition/generate_train_examples_runes.html, line 150 at r1 (raw file):
remove this demos/rune_recognition/rune_recognition.md, line 8 at r1 (raw file):
link to deeplearnjs.org now instead of the old base URL demos/rune_recognition/rune_recognition.md, line 150 at r1 (raw file):
link to deeplearnjs.org now instead of the old base URL demos/rune_recognition/rune_recognition.md, line 154 at r1 (raw file):
can you make this "npm run prep", we need to install bower components for the model builder to work too Comments from Reviewable |
|
Thank you! I've processed the feedback. |
|
Reviewed 2 of 4 files at r1, 2 of 2 files at r2. Comments from Reviewable |
…rflow#156) * Create generate_train_examples_runes.html * Change styling Is it okay if we link the font from an external or should we include it in the repo? It's licensed under the [open font license](http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=OFL) by the way. * Create generate_rune_data_for_model_builder.py * Add files via upload * Create rune_recognition.md * Update rune_recognition.md * Update rune_recognition.md * Update rune_recognition.md * Update rune_recognition.md * Create deleteme.md * Update rune_recognition.md * Update rune_recognition.md * Update rune_recognition.md * Minor text update (cherry picked from commit e2b4f01) * Runeless tutorial * Update text on where to find rune images * Merge branch 'master' into rune_recognition_tutorial_without_images * Use single quotes everywhere * Note that number of labels is different for runes than for MNIST * Merge branch 'master' into rune_recognition_tutorial_without_images * Update generate_train_examples_runes.html * Update rune_recognition.md * Merge branch 'master' into rune_recognition_tutorial_without_images
See also #153. Same commits except for the ~2000 rune images. I made a new branch so that the images don't clutter the git history .
This change is